1. Welcome to the Brawl website! Feel free to look around our forums. Join our growing community by typing /register in-game!

Idea Remove Dead End's Timer

Discussion in 'MinecraftParty Deluxe' started by featherpaw, Jul 27, 2017.

Thread Status:
Please be aware that this thread is more than 30 days old. Do not post unless the topic can still be discussed. Read more...
  1. featherpaw

    featherpaw Your friendly neighborhood kitten! :3

    Joined:
    Aug 16, 2015
    Messages:
    2,548
    Ratings:
    +1,424
    Hey Partiers,

    It's been a while since I've posted an idea like this, but there's a good reason for that, I promise. However, this has been discussed many times ingame without a thread being created, so I figured I'd step up to the plate to make it an "official idea". Keep in mind this isn't my idea only. It was a server-wide discussion that led to this idea being created.

    On dead end it is very common for there to be a two-way, even three-way tie for first place, simply because of how big the map is for the amount of players on at the times that I normally play. While the idea has been suggested of making a smaller map, after talking about it with some people during the game we decided on a much simpler (and easier, in my opinion) idea that would help both busy timezones and non-busy timezones.

    Instead of making a smaller map that would negatively affect busy timezones, why don't we negate the timer on dead end? This would positively affect non-busy timezones while not affecting the busier timezones because of the fact that during busy timezones the time rarely hits 0 without there being a set first place, second place, and third place and because of the fact that during non-busy timezones eventually people will run out of area, ending those 2 or 3 way ties.
     
    • Like Like x 1
  2. charlottethegirl

    charlottethegirl Ex- Party JMOD

    Joined:
    Apr 6, 2016
    Messages:
    783
    Ratings:
    +540
    I did actually suggest removing the timer on spleef and maybe speed up the melting time, and this idea is very similar. This is basically the same thing.
    +1
     
    • Like Like x 1
  3. patrickdemooij9

    patrickdemooij9 Well-Known Member

    Joined:
    Oct 25, 2013
    Messages:
    1,048
    Ratings:
    +384
    Good idea, but might be a bit difficult to code. This is because, if my guess at the coding base is right, that every game needs time. I don't think we can simply change the time to forever without spending some time in the code base.

    Right now, if it needs time in the code, we will probably be better off fixing some other things first.
     
  4. featherpaw

    featherpaw Your friendly neighborhood kitten! :3

    Joined:
    Aug 16, 2015
    Messages:
    2,548
    Ratings:
    +1,424
    I'm assuming all it's using is a simple Bukkit scheduler to keep track of how long the code runs. We could easily set that to a different parameter. Instead of using time as a counter we can use players left. At 1, the game ends and the first, second, and third place winners are returned.
     
  5. patrickdemooij9

    patrickdemooij9 Well-Known Member

    Joined:
    Oct 25, 2013
    Messages:
    1,048
    Ratings:
    +384
    I don't think it's that easy to do.

    McParty probably has something as a game declared. The game needs atleast a few things like spawnpositions and time. Now, we know the game will always have time and we can always access it (Like with the scoreboard).

    However, maybe we can cheat a bit and make it so a time like -1 (something that won't be reached in a normal game) makes it so we have infinite time. So we would checks if the time is equals to -1 and then we won't start a timer. Could work yeah.
     
  6. charlottethegirl

    charlottethegirl Ex- Party JMOD

    Joined:
    Apr 6, 2016
    Messages:
    783
    Ratings:
    +540
    Maybe you could just increase the time to like 10 minutes to it would basically be impossible to end if that is easier to code.
     
  7. featherpaw

    featherpaw Your friendly neighborhood kitten! :3

    Joined:
    Aug 16, 2015
    Messages:
    2,548
    Ratings:
    +1,424
    You don't need a Bukkit scheduler for a class to work and you shouldn't be running everything from one class anyway.
     
  8. Sir_Inge

    Sir_Inge Well-Known Member

    Joined:
    May 22, 2015
    Messages:
    2,371
    Ratings:
    +527
    Real simple solution: Set the time of the game to 86,400 seconds.
     
  9. patrickdemooij9

    patrickdemooij9 Well-Known Member

    Joined:
    Oct 25, 2013
    Messages:
    1,048
    Ratings:
    +384
    That's not what I mean. Look at it this way (this is how I am currently doing it).

    Every minigame in mcparty is declared as a Game, so there are around 20 or so games. Every game could have it's own type: pointsgame, racegame etc.

    Now back to the Game class. Every game needs certain properties to work like time and spawnlocations (I am sure brawl has this aswell).

    So we have around 20 games that all have a time and spawnlocations. Say we have a gamemanager that keeps track of the games and starts them when needed. He needs to know the time as he will start a bukkitrunnable (timer) for that game and end the game when the timer stops. I think Brawl does it this way so we will have to change some things around, though thinking about it, it probably won't be as much as I thought at first, we just need to check it somewhere (like I said in my previous post).
     
  10. featherpaw

    featherpaw Your friendly neighborhood kitten! :3

    Joined:
    Aug 16, 2015
    Messages:
    2,548
    Ratings:
    +1,424
    But games are just a plugin composed of classes and you don't have to make a timer class. bukkitrunnable only creates a countdown until something is run. That something can change, as can the time. Heck, you don't even need a bukkitrunnable.
     
  11. patrickdemooij9

    patrickdemooij9 Well-Known Member

    Joined:
    Oct 25, 2013
    Messages:
    1,048
    Ratings:
    +384
    Doesn't matter to much. You probably have a different solution to making McParty than I do and that's probably what we are arguining about.

    I think it's a good idea, just have to see how long it would take to implement.
     
  12. featherpaw

    featherpaw Your friendly neighborhood kitten! :3

    Joined:
    Aug 16, 2015
    Messages:
    2,548
    Ratings:
    +1,424
    True. There's always more than one way to write code. ^-^
     
  13. Acceqted

    Acceqted New Member

    Joined:
    Aug 16, 2017
    Messages:
    29
    Ratings:
    +4
    Good idea. This needs to be implemented along with Spleef
     
Loading...
Similar Threads Forum Date
Remove all gamemodes that are dead and bring back wild west Off Topic Jan 12, 2021
Remove 21 and add solo option for warz MC-WarZ Jan 21, 2021
Remove this lever, I dislike it MC-WarZ Nov 16, 2020
Idea Remove Cobwebs from Spooky Aquafus Flagroom Capture the Flag Oct 20, 2020
Denied Application Removed Denied Jun 18, 2020
Thread Status:
Please be aware that this thread is more than 30 days old. Do not post unless the topic can still be discussed. Read more...