Flagmod: A modification to re-introduce wool to CTF (WIP)

@NomNuggetNom can you help with this or nah?

 

Couldn't you re-texture the banner in the inv as a wool block?

 

gl building red wool structures :3

 

And there's even the wool fountain... my life is complete.
@KirbysDreamLand That looks amazing

 

I could probably look into it, I think I know what you're talking about... I think I am an experienced a little with coding...

 

I am going to try to add Forge compatibility. This is my function to modify one of the classes.

Code:

    private void transformRenderGlobal(ClassNode classNode, boolean isObf) {
        final String methodName = isObf ? "a" : "renderEntities";
        final String descriptor = isObf ? "(Lpk;Lbia;F)V" : "(Lnet/minecraft/entity/Entity;Lnet/minecraft/client/renderer/culling/ICamera;F)V";
        final String getFieldOwner = isObf ? "bfr" : "net/minecraft/client/renderer/RenderGlobal";
        final String getFieldName = isObf ? "k" : "theWorld";
        final String getFieldDesc = isObf ? "Lbdb;" : "Lnet/minecraft/client/multiplayer/WorldClient;";
        final String nextGetFieldOwner = isObf ? "bdb" : "net/minecraft/client/multiplayer/WorldClient";
        final String nextGetFieldName = isObf ? "B" : "theProfiler";
        final String nextGetFieldDesc = isObf ? "Lnt;" : "Lnet/minecraft/profiler/Profiler;";
        final String cst = "entities";
        AbstractInsnNode insn = null;
        MethodNode mthd = null;
        for(MethodNode method : classNode.methods){
            if(method.name.equals(methodName) && method.desc.equals(descriptor)){
                for(AbstractInsnNode instruction : method.instructions.toArray()){
                    if(instruction.getOpcode() == ALOAD && ((VarInsnNode)instruction).var == 0 && instruction.getNext().getOpcode() == GETFIELD && ((FieldInsnNode)instruction.getNext()).name.equals("theWorld") && instruction.getNext().getNext().getOpcode() == GETFIELD){
                        FieldInsnNode getField = (FieldInsnNode) instruction.getNext();
                        if(getField.owner.equals(getFieldOwner) && getField.name.equals(getFieldName) && getField.desc.equals(getFieldDesc) && getField.getNext().getOpcode() == GETFIELD){
                            FieldInsnNode nextGetField = (FieldInsnNode) getField.getNext();
                            if(nextGetField.owner.equals(nextGetFieldOwner) && nextGetField.name.equals(nextGetFieldName) && nextGetField.desc.equals(nextGetFieldDesc)){
                                if(nextGetField.getNext() instanceof LdcInsnNode){
                                    LdcInsnNode ldc = (LdcInsnNode) nextGetField.getNext();
                                    if(ldc.cst.equals("entities")){
                                        //Call all your m80s, we finally found the right instruction!!!!!!!!
                                        //We'll have a party
                                        insn = instruction;
                                        mthd = method;
                                    }
                                }  
                            }
                        }
                    }
                }
            }
        }
        if(insn == null || mthd == null){
            log("[CRITICAL] Error while patching RenderGlobal. FlagMod entities will not br rendered.");
        }else{
            //mv.visitMethodInsn(INVOKESTATIC, "FlagMod/FlagMod", "getFlagMod", "()LFlagMod/FlagMod;", false);
            //mv.visitVarInsn(FLOAD, 3);
            //mv.visitMethodInsn(INVOKEVIRTUAL, "FlagMod/FlagMod", "render", "(F)V", false);
            MethodInsnNode getFlagMod = new MethodInsnNode(INVOKESTATIC, "FlagMod/FlagMod", "getFlagMod", "()LFlagMod/FlagMod;", false);
            VarInsnNode partialTicks = new VarInsnNode(FLOAD, 3);
            MethodInsnNode render = new MethodInsnNode(INVOKEVIRTUAL, "FlagMod/FlagMod", "render", "(F)V", false);
            mthd.instructions.insertBefore(insn, render);
            mthd.instructions.insertBefore(render, partialTicks);
            mthd.instructions.insertBefore(partialTicks, getFlagMod);
            log("[SUCCESS] Patched RenderGlobal!");
        }
    }

This has been the hardest part, but it works!

All it does is change this

Code:

mv.visitFrame(Opcodes.F_SAME, 0, null, 0, null);
mv.visitVarInsn(ALOAD, 0);

To this

Code:

mv.visitFrame(Opcodes.F_SAME, 0, null, 0, null);
mv.visitMethodInsn(INVOKESTATIC, "FlagMod/FlagMod", "getFlagMod", "()LFlagMod/FlagMod;", false);
mv.visitVarInsn(FLOAD, 3);
mv.visitMethodInsn(INVOKEVIRTUAL, "FlagMod/FlagMod", "render", "(F)V", false);
mv.visitVarInsn(ALOAD, 0);

 

Their shouldn't be the right clicking problem right? Since its just a wool block, if you demonstrated that in your video I may had missed it.

 

Just saying, who likes the banners? I have not seen any posts about telling people to stop asking to bring wool back, as far as i'm aware, no one likes the banners :/ not sure what is better about the banners as opposed to the old fashioned wool... It is just annoying when trying to F5 and get more of a better perspective when you are holding the flag as it obstructs your vision, also it seems to be creating more lag than there used to be.

 

There is still the right click problem. I think it is caused by the armor stand and not the banners.

 

its beautiful C:
the wool is back on ctf

 

ArmorStand ?

 

The Banner isnt a banner, it's a banner being worn as an ArmorStand's head. All complaints towards banners are actually because of the AmorStand, which is what prevents right clicking.

I dont voice my opinion because I consider the whole banner debacle a sign that CTFers will truly complain about some of the stupidest things, but I dont feel any issues against Banners that aren't adjustable.

Once the mod comes out the complaints will hopefully stop.

 

Exactly, I don't care. That's why I dont post about the issue because Banner people have valid complaints, but the complaints are so trivial and adaptable that Im dumbfounded that it's been going on for so long.

I dont know if its commendable that people have stuck to such a cause, or if it's just purely absurd.

 

Because the fact its so trivial and unimportant to the masses of random players who play CTF that it's not worth reverting.